Add NGF telemetry data for TLSRoute#2387
Merged
Merged
Conversation
github-actions
Bot
added
documentation
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2387 +/- ##
==========================================
+ Coverage 88.89% 88.91% +0.01%
==========================================
Files 100 100
Lines 7512 7521 +9
Branches 50 50
==========================================
+ Hits 6678 6687 +9
Misses 778 778
Partials 56 56 ☔ View full report in Codecov by Sentry. |
kate-osborn
approved these changes
Aug 13, 2024
sjberman
approved these changes
Aug 13, 2024
bjee19
force-pushed
the
chore/add-telemetry-for-tls-routes
branch
from
910e267 to
4cc7931
Compare
Contributor
Author
|
Credit to @sarthyparty for the work done in the code, and @salonichf5 for testing the work on the xcdf side! |
Problem: NGF did not support telemetry for TLSRoute Solution: I counted the number of TLSRoutes in the graph and added it to the telemetry data
bjee19
force-pushed
the
chore/add-telemetry-for-tls-routes
branch
from
25b0b8d to
f6475ae
Compare
miledxz
added a commit
to miledxz/nginx-gateway-fabric
that referenced
this pull request
Jan 14, 2025
Problem: NGF did not support telemetry for TLSRoute. Solution: Add telemetry collection of TLSRoute. Testing: Added unit tests for the updated code. Co-authored-by: Sarthak Agrawal <s.agrawal@f5.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: NGF did not support telemetry for TLSRoute.
Solution: Add telemetry collection of TLSRoute.
Testing: Added unit tests for the updated code.
Closes #2286
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.